x86/CPUID: surface suitable value in EBX of XSTATE subleaf 1
authorJan Beulich <jbeulich@suse.com>
Wed, 24 Aug 2022 12:23:59 +0000 (14:23 +0200)
committerHans van Kranenburg <hans@knorrie.org>
Wed, 28 Sep 2022 17:10:42 +0000 (19:10 +0200)
commit5d4ae23ee22ba4bf3cc061ed5f657786060b022b
tree7c06757a9c95133ee81879dc762fd1c3ac710de0
parent6caf631b7b6f6a658efe6b27b24a2dab72947246
x86/CPUID: surface suitable value in EBX of XSTATE subleaf 1

While the SDM isn't very clear about this, our present behavior make
Linux 5.19 unhappy. As of commit 8ad7e8f69695 ("x86/fpu/xsave: Support
XSAVEC in the kernel") they're using this CPUID output also to size
the compacted area used by XSAVEC. Getting back zero there isn't really
liked, yet for PV that's the default on capable hardware: XSAVES isn't
exposed to PV domains.

Considering that the size reported is that of the compacted save area,
I view Linux'es assumption as appropriate (short of the SDM properly
considering the case). Therefore we need to populate the field also when
only XSAVEC is supported for a guest.

Fixes: 460b9a4b3630 ("x86/xsaves: enable xsaves/xrstors for hvm guest")
Fixes: 8d050ed1097c ("x86: don't expose XSAVES capability to PV guests")
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
(cherry picked from commit c3bd0b83ea5b7c0da6542687436042eeea1e7909)
xen/arch/x86/cpuid.c